HonahX commented on code in PR #364: URL: https://github.com/apache/iceberg-python/pull/364#discussion_r1477469426
########## mkdocs/docs/configuration.md: ########## @@ -62,7 +62,16 @@ You can also set the FileIO explicitly: | ---------- | -------------------------------- | ----------------------------------------------------------------------------------------------- | | py-io-impl | pyiceberg.io.fsspec.FsspecFileIO | Sets the FileIO explicitly to an implementation, and will fail explicitly if it can't be loaded | -For the FileIO there are several configuration options available: +General configuration: Review Comment: Shall we have a new section called `Tables` and make these configs under a sub-section `Write properties`. I think it may be better to separate the general table properties from configurations specific to FileIO and Catalogs, which are more vendor specific. Also, I think we can write a note in the new section, indicating that currently pyiceberg write only support certain table write properties. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
