ZENOTME commented on code in PR #185:
URL: https://github.com/apache/iceberg-rust/pull/185#discussion_r1477320178
##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -676,9 +690,10 @@ pub(super) mod _serde {
}
}
- impl From<TableMetadata> for TableMetadataV1 {
- fn from(v: TableMetadata) -> Self {
- TableMetadataV1 {
+ impl TryFrom<TableMetadata> for TableMetadataV1 {
+ type Error = Error;
+ fn try_from(v: TableMetadata) -> Result<Self, Error> {
Review Comment:
If we still use `expect` at following, why we need to convert it to
`try_from`🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
