jqin61 commented on code in PR #353: URL: https://github.com/apache/iceberg-python/pull/353#discussion_r1476487793
########## pyiceberg/table/__init__.py: ########## @@ -2467,3 +2462,131 @@ def commit(self) -> Snapshot: ) return snapshot + + +@dataclass(frozen=True) +class TablePartition: + partition_key: Record + arrow_table_partition: pa.Table + + +def get_partition_sort_order(partition_columns: list[str], reverse: bool = False) -> dict[str, Any]: Review Comment: Yes, thanks for the reminder! More refactoring is on the way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org