XBaith commented on code in PR #8597:
URL: https://github.com/apache/iceberg/pull/8597#discussion_r1474051720
##########
core/src/main/java/org/apache/iceberg/io/RollingFileWriter.java:
##########
@@ -127,9 +130,8 @@ private void closeCurrentWriter() {
if (currentFileRows == 0L) {
try {
io.deleteFile(currentFile.encryptingOutputFile());
- } catch (UncheckedIOException e) {
- // the file may not have been created, and it isn't worth failing
the job to clean up,
- // skip deleting
+ } catch (Throwable t) {
+ LOG.warn("Failed to delete empty file. This may result in empty
orphan files.", t);
Review Comment:
We should also prompt user that "the file may not have been created"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
