danielcweeks commented on code in PR #9292: URL: https://github.com/apache/iceberg/pull/9292#discussion_r1473142384
########## core/src/main/java/org/apache/iceberg/MetadataUpdate.java: ########## @@ -490,4 +491,21 @@ public void applyTo(ViewMetadata.Builder viewMetadataBuilder) { viewMetadataBuilder.setCurrentVersionId(versionId); } } + + class AppendFilesUpdate implements MetadataUpdate { Review Comment: I think we need to initially disallow delete files from being added because there are more concerns around achieving correct semantics. We could split this into `AppendDataFileUpdate` and if we later decide to support deletes, add `AppendDeleteFileUpdate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org