nastra commented on code in PR #9584:
URL: https://github.com/apache/iceberg/pull/9584#discussion_r1471397337
##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
@@ -85,6 +85,8 @@ public void accept(String file) {
private ExecutorService planExecutorService = ThreadPools.getWorkerPool();
private Boolean incrementalCleanup;
+ private List<Snapshot> expiredSnapshots;
Review Comment:
I think it would be better to keep a Set of snapshot IDs, because removing
from a list is O(n)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
