syun64 commented on code in PR #305:
URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1470488890
##########
tests/catalog/test_base.py:
##########
@@ -330,6 +334,34 @@ def test_create_table(catalog: InMemoryCatalog) -> None:
assert catalog.load_table(TEST_TABLE_IDENTIFIER) == table
+@pytest.mark.parametrize(
+ "schema,expected",
+ [
+ (lazy_fixture("pyarrow_schema_simple_without_ids"),
lazy_fixture("iceberg_schema_simple_no_ids")),
+ (lazy_fixture("iceberg_schema_simple"),
lazy_fixture("iceberg_schema_simple")),
+ (lazy_fixture("iceberg_schema_nested"),
lazy_fixture("iceberg_schema_nested")),
+ (lazy_fixture("pyarrow_schema_nested_without_ids"),
lazy_fixture("iceberg_schema_nested_no_ids")),
+ ],
+)
+def test_convert_schema_if_needed(
+ schema: Union[Schema, pa.Schema],
+ expected: Schema,
+ catalog: InMemoryCatalog,
+) -> None:
+ assert expected == catalog._convert_schema_if_needed(schema)
+
+
+def test_create_table_pyarrow_schema(catalog: InMemoryCatalog,
pyarrow_schema_simple_without_ids: pa.Schema) -> None:
+ table = catalog.create_table(
+ identifier=TEST_TABLE_IDENTIFIER,
+ schema=pyarrow_schema_simple_without_ids,
+ location=TEST_TABLE_LOCATION,
+ partition_spec=TEST_TABLE_PARTITION_SPEC,
+ properties=TEST_TABLE_PROPERTIES,
+ )
+ assert catalog.load_table(TEST_TABLE_IDENTIFIER) == table
+
Review Comment:
Thank you for the great suggestion @HonahX .
I just tried to update the test in test_base.py, but it requires us to use
new_table_metadata instead of the existing mechanism of creating a new
TableMetadataV1 instance, which creates a new uuid and breaks the
cli/test_console.py tests.
So I think it might be simpler to fix this once we get
https://github.com/apache/iceberg-python/pull/289 merged in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
