syun64 commented on code in PR #305:
URL: https://github.com/apache/iceberg-python/pull/305#discussion_r1468585068
##########
tests/io/test_pyarrow_visitor.py:
##########
@@ -572,3 +477,15 @@ def
test_pyarrow_schema_to_schema_missing_ids_using_name_mapping_nested_missing_
with pytest.raises(ValueError) as exc_info:
_ = pyarrow_to_schema(schema, name_mapping)
assert "Could not find field with name: quux.value.key" in
str(exc_info.value)
+
+
+def test_pyarrow_schema_to_schema_fresh_ids_simple_schema(
+ pyarrow_schema_simple_without_ids: pa.Schema, iceberg_schema_simple: Schema
+) -> None:
+ assert pre_order_visit_pyarrow(pyarrow_schema_simple_without_ids,
_ConvertToIcebergWithFreshIds()) == iceberg_schema_simple
Review Comment:
That's a sharp observation @kevinjqliu :) However, I don't think there's a
need to check for schema_id equality because a new schema is generated with
INITIAL_SCHEMA_ID in both _SetFreshIDs and _ConvertToIcebergWithFreshIds.
There's an ongoing discussion on this PR that might affect whether or not we
keep this visitor, so I'll leave this suggestion untouched until we reach a
consensus there:
https://github.com/apache/iceberg-python/pull/305#discussion_r1467757335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
