kevinjqliu commented on code in PR #301:
URL: https://github.com/apache/iceberg-python/pull/301#discussion_r1467137427


##########
pyiceberg/io/pyarrow.py:
##########
@@ -288,6 +288,8 @@ def create(self, overwrite: bool = False) -> OutputStream:
         try:
             if not overwrite and self.exists() is True:
                 raise FileExistsError(f"Cannot create file, already exists: 
{self.location}")
+            # Parent directories must be created first in certain file 
systems, such as the LocalFileSystem.
+            self._filesystem.create_dir(os.path.dirname(self._path), 
recursive=True)

Review Comment:
   @Fokko I updated the PR for both PyArrow and FsSpec. 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to