amogh-jahagirdar commented on code in PR #9556:
URL: https://github.com/apache/iceberg/pull/9556#discussion_r1467001797
##########
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMerge.java:
##########
@@ -523,6 +523,58 @@ public void testMergeWithOnlyUpdateClauseAndNullValues() {
sql("SELECT * FROM %s ORDER BY id", selectTarget()));
}
+ @Test
+ public void testMergeWithOnlyUpdateNullUnmatchedValues() {
+ createAndInitTable(
+ "id INT, value INT", "{ \"id\": 1, \"value\": 2 }\n" + "{ \"id\": 6,
\"value\": null }");
+
+ createOrReplaceView("source", "id INT NOT NULL, value INT", "{ \"id\": 1,
\"value\": 100 }\n");
+ sql(
+ "MERGE INTO %s t USING source s "
+ + "ON t.id == s.id "
+ + "WHEN MATCHED THEN "
+ + " UPDATE SET id=123, value=456",
+ commitTarget());
+
+ sql("SELECT * FROM %s", commitTarget());
+
+ ImmutableList<Object[]> expectedRows =
+ ImmutableList.of(
+ row(6, null), // kept
+ row(123, 456)); // updated
+
+ assertEquals(
+ "Should have expected rows",
+ expectedRows,
+ sql("SELECT * FROM %s ORDER BY id", selectTarget()));
+ }
+
+ @Test
+ public void testMergeWithOnlyUpdateSingleFieldNullUnmatchedValues() {
Review Comment:
This test would pass before this change, I added it for additional coverage
and verification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
