jbonofre commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1466256486
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##########
@@ -25,161 +25,177 @@
import java.util.Map;
import java.util.Properties;
import java.util.Set;
+import org.apache.iceberg.BaseMetastoreTableOperations;
import org.apache.iceberg.catalog.Namespace;
import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.relocated.com.google.common.base.Joiner;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.relocated.com.google.common.base.Splitter;
import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
+import org.apache.iceberg.relocated.com.google.common.collect.Maps;
final class JdbcUtil {
// property to control strict-mode (aka check if namespace exists when
creating a table)
static final String STRICT_MODE_PROPERTY = JdbcCatalog.PROPERTY_PREFIX +
"strict-mode";
- // Catalog Table
- static final String CATALOG_TABLE_NAME = "iceberg_tables";
+ // Catalog Table & View
+ static final String CATALOG_TABLE_VIEW_NAME = "iceberg_tables_views";
Review Comment:
Yes. Good point. I think it's better to use the previous table name and
upgrade the schema. I plan to add a check in the initial method to check the
current schema and update to the new one accordingly.
Thanks for pointing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
