Fokko commented on code in PR #171:
URL: https://github.com/apache/iceberg-rust/pull/171#discussion_r1466015499
##########
crates/iceberg/src/spec/manifest.rs:
##########
@@ -1328,16 +1328,11 @@ mod _serde {
) -> Result<HashMap<i32, Literal>, Error> {
let mut m = HashMap::with_capacity(v.len());
for entry in v {
- let data_type = &schema
- .field_by_id(entry.key)
- .ok_or_else(|| {
- Error::new(
- ErrorKind::DataInvalid,
- format!("Can't find field id {} for
upper/lower_bounds", entry.key),
- )
- })?
- .field_type;
- m.insert(entry.key, Literal::try_from_bytes(&entry.value,
data_type)?);
+ // We ignore the entry if the field is not found in the schema,
due to schema evolution.
Review Comment:
This can happen if you drop a column indeed. This makes sense to me 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
