liurenjie1024 commented on issue #165: URL: https://github.com/apache/iceberg-rust/issues/165#issuecomment-1909480901
Hi @Samrose-Ahmed Sorry for late reply. > One is this line ( > > [iceberg-rust/crates/iceberg/src/spec/manifest.rs](https://github.com/apache/iceberg-rust/blob/35f348139ac1697336244fffa4b4b24280ff79ce/crates/iceberg/src/spec/manifest.rs#L1364) > > Line 1364 in [35f3481](https://github.com/apache/iceberg-rust/commit/35f348139ac1697336244fffa4b4b24280ff79ce) > > m.insert(entry.key, entry.value.try_into()?); > ), it needs to be able to handle negative numbers, I had eg null_value_counts where value was -1, I think that can be mapped to 0 here. In what case this might be negative value, i.e. used for `null_value_counts`? Why counts may be negative value? cc @Fokko Any ideas? > In this function ( > > [iceberg-rust/crates/iceberg/src/spec/manifest.rs](https://github.com/apache/iceberg-rust/blob/35f348139ac1697336244fffa4b4b24280ff79ce/crates/iceberg/src/spec/manifest.rs#L1333) > > Line 1333 in [35f3481](https://github.com/apache/iceberg-rust/commit/35f348139ac1697336244fffa4b4b24280ff79ce) > > .ok_or_else(|| { > ) we shouldn't throw this error, but just skip if the field is not found, due to schema evolution. Sound reasonable to me. I will fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
