Xuanwo commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1905335724
> This may make this interface easier to make sense.
The real code could be like:
```rust
let writer = FileWriterHelper::new(builder_a)
.layer(builder_b)
.layer(builder_c)
.finish(builder_d)
.layer(builder_e)
.layer(builder_f)
.build()
.await
.unwrap();
```
Which is harder to understand. The original design like the following is
verbose but much easier to read even when we not designed the var names
carefully.
```rust
let builder = ParquetFileWriterBuilder::new(parquet_file_writer_config);
let builder = DataFileWriterBuilder::new(builder,data_file_writer_config);
let writer = builder.build(schema).await?;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
