kevinjqliu commented on issue #290: URL: https://github.com/apache/iceberg-python/issues/290#issuecomment-1904519923
Somewhat related, I noticed that `Schema` class `__eq__` function does not check if the `schema_id`s are equal. See https://github.com/apache/iceberg-python/blob/a56838dc5d9acc5f0e0d70919bfc433c7d0756f1/pyiceberg/schema.py#L104-L118 In `test_add_column`, it checks if the two schemas are equal using `schema_id=0` which is wrong, it should be `schema_id=1` in L602 since schema evolution just happened https://github.com/apache/iceberg-python/blob/main/tests/catalog/test_base.py#L592-L618 Should I file this as a seperate issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
