zinking commented on code in PR #9454:
URL: https://github.com/apache/iceberg/pull/9454#discussion_r1461354262


##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -289,13 +321,38 @@ private void invalidateFilteredCache() {
     cleanUncommitted(SnapshotProducer.EMPTY_SET);
   }
 
+  private void recordPartitionMinDataSequenceNumber(ManifestFile manifest) {

Review Comment:
   agree that adding this on the general write path is too heavy, so that's why 
I prefer it enabled during rewrite, or probably just some of the rewrites.
   
   on the other hand, it sounds reasonable to track this on partition metadata, 
but there has to be somewhere to calculate it anyways. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to