mudit-97 commented on code in PR #9479:
URL: https://github.com/apache/iceberg/pull/9479#discussion_r1461333593
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -104,19 +104,21 @@
import org.apache.parquet.column.ParquetProperties.WriterVersion;
import org.apache.parquet.crypto.FileDecryptionProperties;
import org.apache.parquet.crypto.FileEncryptionProperties;
-import org.apache.parquet.hadoop.ParquetFileReader;
-import org.apache.parquet.hadoop.ParquetFileWriter;
-import org.apache.parquet.hadoop.ParquetOutputFormat;
+import org.apache.parquet.hadoop.*;
Review Comment:
@ajantha-bhat yes I have fixed this in my local, fixing 1 Integration test
case, then will push it again
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1160,8 +1162,37 @@ public <D> CloseableIterable<D> build() {
optionsBuilder.withDecryption(fileDecryptionProperties);
}
+ boolean pushedFilters = true;
ParquetReadOptions options = optionsBuilder.build();
+ if (filter != null) {
Review Comment:
ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
