danielcweeks commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1460673422
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -115,40 +126,22 @@ public void initialize(String inputName, Map<String,
String> properties) {
@Override
public List<TableIdentifier> listTables(Namespace namespace) {
- Preconditions.checkArgument(
- isValidateNamespace(namespace), "Missing database in namespace: %s",
namespace);
- String database = namespace.level(0);
try {
- List<String> tableNames = clients.run(client ->
client.getAllTables(database));
List<TableIdentifier> tableIdentifiers;
if (listAllTables) {
- tableIdentifiers =
- tableNames.stream()
- .map(t -> TableIdentifier.of(namespace, t))
- .collect(Collectors.toList());
+ tableIdentifiers = listAllTables(namespace);
} else {
- List<Table> tableObjects =
- clients.run(client -> client.getTableObjectsByName(database,
tableNames));
tableIdentifiers =
- tableObjects.stream()
- .filter(
- table ->
- table.getParameters() != null
- &&
BaseMetastoreTableOperations.ICEBERG_TABLE_TYPE_VALUE
Review Comment:
I'm concerned that this is changing behavior for the catalog. There was no
filter on external table types previously and I don't believe that was actually
required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
