danielcweeks commented on code in PR #9523:
URL: https://github.com/apache/iceberg/pull/9523#discussion_r1459891880
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -1022,11 +1022,17 @@ public void commitTransaction(SessionContext context,
List<TableCommit> commits)
UpdateTableRequest.create(commit.identifier(),
commit.requirements(), commit.updates()));
}
+ Map<String, String> props = properties();
+ if (null != context.credentials()) {
+ props = RESTUtil.merge(properties(), context.credentials());
+ }
+
+ AuthSession authSession = tableSession(props, session(context));
Review Comment:
I think we should use the catalog session here instead of a table session.
The table session is intended to be scoped to a particular table, but this is a
cross-table operation and should be handled as a catalog level using the
`catalogAuth`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
