nk1506 commented on issue #9514: URL: https://github.com/apache/iceberg/issues/9514#issuecomment-1898660780
> @nk1506 which particular methods did you have in mind that would make sense to extract into `IcebergMetadata`? I'm not sure this is something we'd want to do. `ViewMetadata` is an interface where the impl is generated by Immutables, whereas `TableMetadata` is a normal class. Even if we'd have `IcebergMetadata` defined as an interface with a few common methods, would this make certain things easier? To simplify TableOperations and ViewOperations I think extracting at least following methods will help: - `List<Schema> schemas();` - `Map<String, String> properties();` - `String metadataFileLocation();` - `String location();` - If we are going to keep previous metadata files for view then `MetadataLogEntry` I did a small [poc](https://github.com/apache/iceberg/pull/9461/files#diff-5ecfc223b311b523a12be7482b6235318fdd7535c371f899daf7e09eacddad77) with Hive catalog but mostly with generic class. It makes code more cleaner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
