nastra commented on code in PR #9439:
URL: https://github.com/apache/iceberg/pull/9439#discussion_r1457310272


##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/sql/TestCreateTableAsSelect.java:
##########
@@ -100,6 +101,15 @@ public void testPartitionedCTAS() {
         "Should have rows matching the source table",
         sql("SELECT * FROM %s ORDER BY id", sourceName),
         sql("SELECT * FROM %s ORDER BY id", tableName));
+
+    // Write distribution mode is not respected before Spark 3.5.0
+    Assert.assertThrows(

Review Comment:
   this should use `Assertions.assertThatThrownBy(() -> 
...).isInstanceOf(SparkException.class).hasMessage(...)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to