Xuanwo commented on code in PR #168: URL: https://github.com/apache/iceberg-rust/pull/168#discussion_r1456983545
########## crates/iceberg/src/writer/file_writer/mod.rs: ########## @@ -0,0 +1,38 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! This module contains the writer for data file format supported by iceberg: parquet, orc. + +use super::{CurrentFileStatus, DefaultOutput}; +use crate::Result; +use arrow_array::RecordBatch; + +/// File writer builder trait. +pub trait FileWriterBuilder<O = DefaultOutput>: Send + Clone + 'static { + /// The associated file writer type. + type R: FileWriter<O>; + /// Build file writer. + fn build(self) -> impl std::future::Future<Output = Result<Self::R>> + Send; Review Comment: nit: How about using `Future` here for short? ########## crates/iceberg/src/writer/file_writer/mod.rs: ########## @@ -0,0 +1,38 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! This module contains the writer for data file format supported by iceberg: parquet, orc. + +use super::{CurrentFileStatus, DefaultOutput}; +use crate::Result; +use arrow_array::RecordBatch; + +/// File writer builder trait. +pub trait FileWriterBuilder<O = DefaultOutput>: Send + Clone + 'static { + /// The associated file writer type. + type R: FileWriter<O>; + /// Build file writer. + fn build(self) -> impl std::future::Future<Output = Result<Self::R>> + Send; +} + +/// File writer focus on writing record batch to different physical file format.(Such as parquet. orc) +pub trait FileWriter<O = DefaultOutput>: Send + 'static + CurrentFileStatus { + /// Write record batch to file. + fn write(&mut self, batch: &RecordBatch) -> impl std::future::Future<Output = Result<()>> + Send; + /// Close file writer. + fn close(self) -> impl std::future::Future<Output = Result<O>> + Send; Review Comment: the same. ########## crates/iceberg/src/writer/file_writer/mod.rs: ########## @@ -0,0 +1,38 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! This module contains the writer for data file format supported by iceberg: parquet, orc. + +use super::{CurrentFileStatus, DefaultOutput}; +use crate::Result; +use arrow_array::RecordBatch; + +/// File writer builder trait. +pub trait FileWriterBuilder<O = DefaultOutput>: Send + Clone + 'static { + /// The associated file writer type. + type R: FileWriter<O>; + /// Build file writer. + fn build(self) -> impl std::future::Future<Output = Result<Self::R>> + Send; +} + +/// File writer focus on writing record batch to different physical file format.(Such as parquet. orc) +pub trait FileWriter<O = DefaultOutput>: Send + 'static + CurrentFileStatus { Review Comment: nit: please place `'static` at the end of this line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
