jbonofre commented on PR #9487: URL: https://github.com/apache/iceberg/pull/9487#issuecomment-1894252812
Few notes about this PR: 1. In `JdbcUtil`, I used methods to generate the SQL statement for table and view as it's very similar. I used a `boolean` to define if the generated SQL statement targets a table or a view. For clarity, I can define an `enum` instead of `boolean`. 2. I verified the JDBC catalog for both table and view using `ViewCatalogTests` and `CatalogTests`. @nastra @rdblue do you mind to take a look ? Thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
