chinmay-bhat commented on code in PR #9380:
URL: https://github.com/apache/iceberg/pull/9380#discussion_r1446464863
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestReadProjection.java:
##########
@@ -36,23 +38,19 @@
import org.apache.iceberg.relocated.com.google.common.collect.Sets;
import org.apache.iceberg.types.Comparators;
import org.apache.iceberg.types.Types;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
+import org.junit.jupiter.api.TestTemplate;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.io.TempDir;
+@ExtendWith(ParameterizedTestExtension.class)
public abstract class TestReadProjection {
- final String format;
Review Comment:
`format` isn't actively being used anywhere in the file. It's only in the
commented code of a few tests.
So I'm not sure if its needed
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReadProjection.java:
##########
@@ -51,40 +55,36 @@
import org.apache.spark.sql.Dataset;
import org.apache.spark.sql.Row;
import org.apache.spark.sql.SparkSession;
-import org.junit.AfterClass;
-import org.junit.Assert;
-import org.junit.BeforeClass;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
+import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.extension.ExtendWith;
-@RunWith(Parameterized.class)
+@ExtendWith(ParameterizedTestExtension.class)
public class TestSparkReadProjection extends TestReadProjection {
private static SparkSession spark = null;
- @Parameterized.Parameters(name = "format = {0}, vectorized = {1},
planningMode = {2}")
+ @Parameters(name = "format = {0}, vectorized = {1}, planningMode = {2}")
public static Object[][] parameters() {
return new Object[][] {
- {"parquet", false, LOCAL},
- {"parquet", true, DISTRIBUTED},
- {"avro", false, LOCAL},
- {"orc", false, DISTRIBUTED},
- {"orc", true, LOCAL}
+ {FileFormat.PARQUET, false, LOCAL},
+ {FileFormat.PARQUET, true, DISTRIBUTED},
+ {FileFormat.AVRO, false, LOCAL},
+ {FileFormat.ORC, false, DISTRIBUTED},
+ {FileFormat.ORC, true, LOCAL}
};
}
- private final FileFormat format;
- private final boolean vectorized;
- private final PlanningMode planningMode;
+ @Parameter(index = 0)
+ private FileFormat format;
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
