nastra commented on code in PR #9380:
URL: https://github.com/apache/iceberg/pull/9380#discussion_r1445298490
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestPartitionValues.java:
##########
@@ -102,35 +105,33 @@ public static Object[][] parameters() {
private static SparkSession spark = null;
- @BeforeClass
+ @BeforeAll
public static void startSpark() {
TestPartitionValues.spark =
SparkSession.builder().master("local[2]").getOrCreate();
}
- @AfterClass
+ @AfterAll
public static void stopSpark() {
SparkSession currentSpark = TestPartitionValues.spark;
TestPartitionValues.spark = null;
currentSpark.stop();
}
- @Rule public TemporaryFolder temp = new TemporaryFolder();
+ @TempDir private Path temp;
- private final String format;
- private final boolean vectorized;
+ @Parameter(index = 0)
+ private String format;
- public TestPartitionValues(String format, boolean vectorized) {
- this.format = format;
- this.vectorized = vectorized;
- }
+ @Parameter(index = 1)
+ private boolean vectorized;
- @Test
+ @TestTemplate
public void testNullPartitionValue() throws Exception {
String desc = "null_part";
- File parent = temp.newFolder(desc);
+ File parent = new File(temp.toFile(), desc);
Review Comment:
should this actually do `temp.resolve(desc)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
