Fokko commented on code in PR #9419:
URL: https://github.com/apache/iceberg/pull/9419#discussion_r1444539888


##########
api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java:
##########
@@ -54,7 +54,7 @@ public boolean equals(Object other) {
     CharSequenceWrapper that = (CharSequenceWrapper) other;
 
     if (wrapped instanceof String && that.wrapped instanceof String) {
-      return wrapped.equals(that.wrapped);
+      return wrapped.toString().contentEquals(that.wrapped);

Review Comment:
   Thanks for looking into this @ajantha-bhat, but there is a fair chance that 
this was intentional for performance reasons.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to