liurenjie1024 commented on code in PR #129: URL: https://github.com/apache/iceberg-rust/pull/129#discussion_r1441253820
########## crates/iceberg/src/spec/manifest_list.rs: ########## @@ -628,6 +630,30 @@ impl TryFrom<i32> for ManifestContentType { } } +impl ManifestListEntry { Review Comment: Yes, I think we will need to some rename to make it more similar to java/python implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org