szehon-ho commented on code in PR #8755: URL: https://github.com/apache/iceberg/pull/8755#discussion_r1441178910
########## core/src/main/java/org/apache/iceberg/deletes/EmptyPositionDeleteIndex.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.deletes; + +class EmptyPositionDeleteIndex implements PositionDeleteIndex { + + private static final EmptyPositionDeleteIndex INSTANCE = new EmptyPositionDeleteIndex(); + + private EmptyPositionDeleteIndex() {} + + static EmptyPositionDeleteIndex get() { + return INSTANCE; + } + + @Override + public void delete(long position) { + throw new UnsupportedOperationException("Cannot modify " + getClass().getName()); + } + + @Override + public void delete(long posStart, long posEnd) { + throw new UnsupportedOperationException("Cannot modify " + getClass().getName()); + } + + @Override + public boolean isDeleted(long position) { + return false; + } + + @Override + public boolean isEmpty() { + return true; + } + + @Override + public String toString() { + return "PositionDeleteIndex{}"; Review Comment: Ah ok, I think i did not see {} here. But actually, I see that we dont have toString on the other PositionDeleteIndex implementations to make the {} have any significance by contrast, maybe we should add those at some point? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
