rdblue commented on code in PR #9359:
URL: https://github.com/apache/iceberg/pull/9359#discussion_r1440793961


##########
core/src/main/java/org/apache/iceberg/encryption/StandardKeyMetadata.java:
##########
@@ -31,7 +31,7 @@
 import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
 import org.apache.iceberg.types.Types;
 
-class StandardKeyMetadata implements EncryptionKeyMetadata, IndexedRecord {
+public class StandardKeyMetadata implements EncryptionKeyMetadata, 
IndexedRecord {

Review Comment:
   We can't make this class public because it implements an Avro interface. If 
it needs to be public, we will have to extract `StandardKeyMetadata` as an 
interface.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to