aokolnychyi commented on code in PR #8755:
URL: https://github.com/apache/iceberg/pull/8755#discussion_r1440362963
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -224,14 +223,10 @@ public Predicate<T> eqDeletedRowFilter() {
}
public PositionDeleteIndex deletedRowPositions() {
- if (posDeletes.isEmpty()) {
- return null;
+ if (deleteRowPositions == null && !posDeletes.isEmpty()) {
Review Comment:
We did not have it before so I think it should be OK. Also, adding double
check locking would require an extra field to synchronize as `deleteLoader()`
already synchronizes on `this`.
Let me think a bit about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
