nastra commented on code in PR #9367:
URL: https://github.com/apache/iceberg/pull/9367#discussion_r1436381154
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##########
@@ -516,17 +527,16 @@ public void testProperties() throws Exception {
expectedProps.put("dogs", "sundance");
for (Map.Entry<String, String> entry : expectedProps.entrySet()) {
- Assert.assertTrue(
- "Created table missing property " + entry.getKey(),
- table.properties().containsKey(entry.getKey()));
- Assert.assertEquals(
- "Property value is not the expected value",
- entry.getValue(),
- table.properties().get(entry.getKey()));
+ assertThat(table.properties())
Review Comment:
these two assertions can be simplified to a single one using
`containsEntry(...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
