rdblue commented on PR #6004: URL: https://github.com/apache/iceberg/pull/6004#issuecomment-1868125419
@wmoustafa, I just opened a refactor that should make this a lot easier to get in: https://github.com/apache/iceberg/pull/9366 When I went to thoroughly review this, I had to do a lot of research into how `buildAvroProjection` works and how this changes it. It is really hard to make changes like this given how complex that projection process is. To solve the problem, I refactored to pull all of the constant and default value logic into the read builder. now it's simpler and can easily be extended with default values. The builder also now uses the expected Iceberg schema directly so that we can now just add cases to add readers that supply default values as constants, like how the code works for [partition constants](https://github.com/apache/iceberg/pull/9366/files#diff-3ad8bf8783152a0f8c9cf75ab07227fab6c9bcfaf3e80ce5915a045e0a3c1cb8R140-R141). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
