liurenjie1024 commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1434681128
########## crates/iceberg/src/expr/bound.rs: ########## @@ -0,0 +1,41 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! This module defines bound expressions. + +use crate::expr::Operator; +use crate::spec::{Literal, NestedFieldRef}; + +/// Bound expression. +pub enum Bound { + /// Constants such as 1, 'a', true, false, null. + Literal(Literal), + /// Reference to some field in schema + Reference { + /// Original name + name: String, Review Comment: TBH I have no idea why this is kept, I see java implementation have this: https://github.com/apache/iceberg/blob/7f2bd24049864b2c6145fdacbd9a3dfca4db857b/api/src/main/java/org/apache/iceberg/expressions/BoundReference.java#L29 It's ok to remove for now if we don't know any actual usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
