Fokko commented on code in PR #209:
URL: https://github.com/apache/iceberg-python/pull/209#discussion_r1434014214
##########
tests/expressions/test_parser.py:
##########
@@ -199,3 +200,8 @@ def test_with_function() -> None:
parser.parse("foo = 1 and lower(bar) = '2'")
assert "Expected end of text, found 'and'" in str(exc_info)
+
+
+def test_cast() -> None:
+ cast = parser.parse("CAST(created_at as date)")
Review Comment:
I would love to see some more tests here. The most important part that's
missing here is converting `date` to a `DayTransform`. Other options such as
`year`, `month` etc should be added as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
