nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1432509022
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java:
##########
@@ -458,19 +457,20 @@ private void testFilterExp(Expression filter, String
sqlFilter, boolean caseSens
TestHelpers.assertRecords(actual, expectedRecords.subList(1, 3),
TestFixtures.SCHEMA);
}
- @Test
+ @TestTemplate
public void testFilterExp() throws Exception {
- testFilterExp(Expressions.greaterThanOrEqual("data", "b"), "where
data>='b'", true);
+ testFilterExp(Expressions.greaterThanOrEqual("data", "b"), "where
data>='b'", true, fileFormat);
Review Comment:
is this change necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
