mas-chen commented on code in PR #9308:
URL: https://github.com/apache/iceberg/pull/9308#discussion_r1431879530
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/reader/IcebergSourceSplitReader.java:
##########
@@ -112,8 +149,20 @@ public void
handleSplitsChanges(SplitsChange<IcebergSourceSplit> splitsChange) {
metrics.incrementAssignedBytes(calculateBytes(splitsChange));
}
+ /**
+ * WakeUp is called by Flink to unblock a reader blocked in {@link #fetch()}
before calling {@link
+ * #handleSplitsChanges(SplitsChange)} or {@link
#pauseOrResumeSplits(Collection, Collection)} to
+ * update the splits or splits state. After {@link #wakeUp()} the specific
method will be called
+ * before calling the {@link #fetch()} again.
+ */
@Override
- public void wakeUp() {}
+ public void wakeUp() {
Review Comment:
Should we wakeup if there are no pending splits? I'm trying to reason the
previous behavior with wakeup being noop. I suppose wakeup was noop because the
source only handles one split, so fetch and handleSplitChanges never occur
together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
