dramaticlly opened a new pull request, #9344:
URL: https://github.com/apache/iceberg/pull/9344

   Today we have open-api specification validated as part of github 
actions/workflow when PR was submitted (or by author running make task)
   
   This PR tried to use 
[openapi-generator-gradle-plugin](https://github.com/OpenAPITools/openapi-generator/tree/master/modules/openapi-generator-gradle-plugin)
 for open-api specification validation on build, with recommendations. I added 
validation to both `s3-signer-open-api.yaml` and `rest-catalog-open-api.yaml`
   
   
   Good spec
   ```
   ./gradlew :iceberg-open-api:build
   Starting a Gradle Daemon (subsequent builds will be faster)
   
   > Task :iceberg-open-api:validateRESTCatalogSpec
   Validating spec 
/Users/stevezhang/workspace/iceberg/open-api/rest-catalog-open-api.yaml
   Spec is valid.
   ```
   
   Bad spec
   ```
   > Task :iceberg-open-api:validateRESTCatalogSpec FAILED
   Validating spec 
/Users/stevezhang/workspace/iceberg/open-api/rest-catalog-open-api.yaml
   
   Spec is invalid.
   Issues:
   
           attribute .servers.foo is unexpected
   
           attribute .servers.url is missing
   
   
   FAILURE: Build failed with an exception.
   
   * What went wrong:
   Execution failed for task ':iceberg-open-api:validateRESTCatalogSpec'.
   > Validation failed.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to