stevenzwu commented on code in PR #9308: URL: https://github.com/apache/iceberg/pull/9308#discussion_r1431740597
########## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/reader/IcebergSourceSplitReader.java: ########## @@ -46,6 +51,8 @@ class IcebergSourceSplitReader<T> implements SplitReader<RecordAndPosition<T>, I private final SerializableComparator<IcebergSourceSplit> splitComparator; private final int indexOfSubtask; private final Queue<IcebergSourceSplit> splits; + private final Set<String> pausedSplits; + private final AtomicBoolean wakeUp = new AtomicBoolean(false); Review Comment: nit: since we are using `synchronized` block, wondering what is the typical style: plain boolean vs AtomicBoolean? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
