Xuanwo commented on code in PR #129:
URL: https://github.com/apache/iceberg-rust/pull/129#discussion_r1431086282
##########
crates/iceberg/src/spec/datatypes.rs:
##########
@@ -523,14 +523,16 @@ impl From<SerdeNestedField> for NestedField {
impl From<NestedField> for SerdeNestedField {
fn from(value: NestedField) -> Self {
+ let initial_default = value.initial_default.map(|x|
x.try_into_json(&value.field_type).expect("We should have checked this in
NestedField::with_initial_default, it can't be converted to json value"));
Review Comment:
Seems we need to rebase the branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
