rdblue commented on code in PR #7844:
URL: https://github.com/apache/iceberg/pull/7844#discussion_r1430498570
##########
core/src/main/java/org/apache/iceberg/util/ParallelIterable.java:
##########
@@ -53,7 +57,8 @@ public CloseableIterator<T> iterator() {
private final Iterator<Runnable> tasks;
private final ExecutorService workerPool;
private final Future<?>[] taskFutures;
- private final ConcurrentLinkedQueue<T> queue = new
ConcurrentLinkedQueue<>();
+ private final LinkedBlockingQueue<T> queue =
+ new LinkedBlockingQueue<>(MANIFEST_READER_QUEUE_SIZE);
Review Comment:
@Heltman, we typically avoid system or environment config. A more
appropriate place for this is in the engine's config. Then it can pass that
configuration down. For example, Flink passes threadpools into the scan API
rather than using the common worker pool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
