dramaticlly commented on code in PR #9305:
URL: https://github.com/apache/iceberg/pull/9305#discussion_r1430486073


##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -117,6 +117,11 @@ public static void dropTableData(FileIO io, TableMetadata 
metadata) {
         Iterables.transform(metadata.previousFiles(), 
TableMetadata.MetadataLogEntry::file),
         "previous metadata",
         true);
+    deleteFiles(
+        io,
+        Iterables.transform(metadata.statisticsFiles(), StatisticsFile::path),
+        "statistic",

Review Comment:
   thank you @ajantha-bhat , I used `statistic` earlier due to singular nouns 
here given how all existing code refer to file type, like `manifest`, `manifest 
list` and `previous metadata`. But I now recognize that the class name is 
already defined as `api/src/main/java/org/apache/iceberg/StatisticsFile.java`. 
let me update to your suggestion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to