pvary commented on code in PR #9321:
URL: https://github.com/apache/iceberg/pull/9321#discussion_r1430040455
##########
jmh.gradle:
##########
@@ -21,10 +21,15 @@ if (jdkVersion != '8' && jdkVersion != '11' && jdkVersion
!= '17') {
throw new GradleException("The JMH benchamrks must be run with JDK 8 or JDK
11 or JDK 17")
}
+def flinkVersions = (System.getProperty("flinkVersions") != null ?
System.getProperty("flinkVersions") :
System.getProperty("defaultFlinkVersions")).split(",")
def sparkVersions = (System.getProperty("sparkVersions") != null ?
System.getProperty("sparkVersions") :
System.getProperty("defaultSparkVersions")).split(",")
def scalaVersion = System.getProperty("scalaVersion") != null ?
System.getProperty("scalaVersion") : System.getProperty("defaultScalaVersion")
def jmhProjects = [project(":iceberg-core")]
+if (flinkVersions.contains("1.17")) {
Review Comment:
nit: Could we move the whole patch to v1.18, and add it there first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
