pvary opened a new pull request, #9308:
URL: https://github.com/apache/iceberg/pull/9308
Fix unit test failures found here: #9216
Before the changes it was not possible to run the tests multiple times using
IntelliJ.
Removed the `static` from `InMemoryReporter` so the tests could be run in a
chain.
Also removed the 1.7 slf4j from the classpath which caused issues with the
test logging.
Run the tests multiple times, and applied the following fixes:
- Added a wait until all the task managers become active:
```
CommonTestUtils.waitForAllTaskRunning(
miniClusterResource.getMiniCluster(), jobClient.getJobID(), false);
```
- Found that the `IcebergSourceSplitReader` does not implement the
`pauseOrResumeSplits` method. As a result the test sometimes failed with
complaining that `pipeline.watermark-alignment.allow-unaligned-source-splits`
should be set. See:
https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/#pipeline-watermark-alignment-allow-unaligned-source-splits.
This is quite a cool feature, and easy to implement, so added the
implementation and the related test to the fix.
After all of these fixes, I was able to run the test 1000 times in a row
without a failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
