ajantha-bhat commented on code in PR #8502: URL: https://github.com/apache/iceberg/pull/8502#discussion_r1427954785
########## api/src/main/java/org/apache/iceberg/PartitionStatisticsFile.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.io.Serializable; + +/** + * Represents a partition statistics file that can be used to read table data more efficiently. + * + * <p>Statistics are informational. A reader can choose to ignore statistics information. Statistics + * support is not required to read the table correctly. + */ +public interface PartitionStatisticsFile extends Serializable { Review Comment: Ack. We can add it back if required during an end to end implementation. ########## core/src/main/java/org/apache/iceberg/TableMetadata.java: ########## @@ -946,15 +955,25 @@ private Builder(TableMetadata base) { this.previousFileLocation = base.metadataFileLocation; this.previousFiles = base.previousFiles; this.refs = Maps.newHashMap(base.refs); - this.statisticsFiles = - base.statisticsFiles.stream().collect(Collectors.groupingBy(StatisticsFile::snapshotId)); - + this.statisticsFiles = statsFileBySnapshotID(base); + this.partitionStatisticsFiles = partitionStatsFileBySnapshotID(base); this.snapshotsById = Maps.newHashMap(base.snapshotsById); this.schemasById = Maps.newHashMap(base.schemasById); this.specsById = Maps.newHashMap(base.specsById); this.sortOrdersById = Maps.newHashMap(base.sortOrdersById); } + private static Map<Long, List<StatisticsFile>> statsFileBySnapshotID(TableMetadata base) { Review Comment: moved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
