JFinis opened a new issue, #9307:
URL: https://github.com/apache/iceberg/issues/9307

   ### Apache Iceberg version
   
   1.4.2 (latest release)
   
   ### Query engine
   
   None
   
   ### Please describe the bug 🐞
   
   The spec is incomplete w.r.t. the mapping of Iceberg types to Avro types. 
Specifically, for the types 
[decimal](https://github.com/apache/iceberg/blob/d56dd63f8e26fe08025933f33176599703013844/format/spec.md?plain=1#L924C1-L924C1),
 
[uuid](https://github.com/apache/iceberg/blob/d56dd63f8e26fe08025933f33176599703013844/format/spec.md?plain=1#L932),
 and 
[fixed](https://github.com/apache/iceberg/blob/d56dd63f8e26fe08025933f33176599703013844/format/spec.md?plain=1#L933),
 the spec defines the Avro type to be `fixed` with appropriate size. However, 
the spec does not say what the name of the fixed should be or that the fixed 
may have an arbitrary name. The problem with this is that Avro mandates that 
fixed types have names. Thus, the type mapping as displayed in the Iceberg spec 
would lead to an invalid Avro type.
   
   Thus, the spec should either decide which name to give to the fixed types in 
Avro, or should mention that implementations are free to choose any name, but 
they have to choose one.
   
   For reference: The implementation chooses the following names:
   
   uuid: 
[`uuid_fixed`](https://github.com/apache/iceberg/blob/d56dd63f8e26fe08025933f33176599703013844/core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java#L49)
   decimal(p,s): 
[`decimal_<p>_<s>`](https://github.com/apache/iceberg/blob/d56dd63f8e26fe08025933f33176599703013844/core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java#L232C56-L232C56)
   fixed(L): 
[`fixed_<L>`](https://github.com/apache/iceberg/blob/d56dd63f8e26fe08025933f33176599703013844/core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java#L221C46-L221C72)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to