jasonf20 commented on code in PR #9230:
URL: https://github.com/apache/iceberg/pull/9230#discussion_r1427375881
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -487,7 +487,11 @@ protected void cleanAll() {
}
protected void deleteFile(String path) {
- deleteFunc.accept(path);
+ try {
+ deleteFunc.accept(path);
+ } catch (RuntimeIOException ignored) {
+ // Allow other deletes to run even if this one fails
Review Comment:
Oddly enough this happened in the test and caused the TransactionTest to
pass even with the bug. Because it failed to delete a file in `cleanAll`
(probably a different issue worth investigating) it skipped part of the
deletion causing the cached metadata to remain valid by chance.
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -487,7 +487,11 @@ protected void cleanAll() {
}
protected void deleteFile(String path) {
- deleteFunc.accept(path);
+ try {
+ deleteFunc.accept(path);
+ } catch (RuntimeIOException ignored) {
+ // Allow other deletes to run even if this one fails
Review Comment:
Found and fixed this bug as well (4th commit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
