deniskuzZ commented on code in PR #9301:
URL: https://github.com/apache/iceberg/pull/9301#discussion_r1426947971
##########
orc/src/main/java/org/apache/iceberg/orc/OrcIterable.java:
##########
@@ -134,7 +134,13 @@ private static VectorizedRowBatchIterator newOrcIterator(
try {
return new VectorizedRowBatchIterator(
- file.location(), readerSchema, orcFileReader.rows(options),
recordsPerBatch);
+ file.location(), readerSchema, orcFileReader.rows(options),
recordsPerBatch) {
+ @Override
+ public void close() throws IOException {
Review Comment:
OrcIterable also extends CloseableGroup and adds orcFileReader to closeable,
but it never gets invoked. MergeIterator is operating on a CloseableIterator
that might have filter and transformations and losses the closeable.
In case of `ParquetInterable` we close the reader.
````
public void close() throws IOException {
ParquetReader.close();
}
}
````
but that's not. the case for OrcIterable that uses
`VectorizedRowBatchIterator`
````
@Override
public void close() throws IOException {
orcFileReader.rows(options).close();
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
