pvary commented on PR #8195: URL: https://github.com/apache/iceberg/pull/8195#issuecomment-1855685224
> Currently, equality columns are parsed from primary key specified in Flink create table statement. However, an Iceberg table might have been created without primary key, but we still want to upsert with Flink. In this case, we need another way to specify equality columns. This PR attempts to solve it with write options. Wouldn't be a better solution to just update the table definition? If the given columns are really primary keys, then the table would benefit from the better specification. If it is not really a primary key, then there could be data corruption when using it as a primary key for upserts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
