pvary commented on code in PR #9143:
URL: https://github.com/apache/iceberg/pull/9143#discussion_r1426541260
##########
common/src/main/java/org/apache/iceberg/common/DynConstructors.java:
##########
@@ -67,7 +66,6 @@ public C newInstance(Object... args) {
try {
return newInstanceChecked(args);
} catch (Exception e) {
- Throwables.propagateIfInstanceOf(e, RuntimeException.class);
Review Comment:
I do not think it is safe to remove.
The result is that the `RuntimeException`s will be wrapped in a new
exception which will cause issues with error handling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
