manuzhang opened a new pull request, #9294: URL: https://github.com/apache/iceberg/pull/9294
As found in https://github.com/apache/iceberg/actions/runs/7191749083/job/19586958583?pr=9273 ``` TestRemoveOrphanFilesAction3 > orphanedFileRemovedWithParallelTasks FAILED java.lang.AssertionError: Should delete 4 files expected:<4> but was:<3> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.apache.iceberg.spark.actions.TestRemoveOrphanFilesAction.orphanedFileRemovedWithParallelTasks(TestRemoveOrphanFilesAction.java:306) ``` The check of `deleteThreads` has passed means delete function is working but `deleteFiles` is not correctly modified since `HashSet` is not thread-safe. ``` Assert.assertEquals( deleteThreads, Sets.newHashSet( "remove-orphan-0", "remove-orphan-1", "remove-orphan-2", "remove-orphan-3")); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
